Re: SATA DMA problem (sata_uli)

From: Tejun Heo
Date: Wed Dec 27 2006 - 08:45:33 EST


Tejun Heo wrote:
> I'm just gonna ack Alan's patch.
>
> * ATA_FLAG_NO_LEGACY is not really used widely (and thus LLDs don't set
> it rigorously). I think it should be removed once we get initialization
> model right.
>
> * I'm really reluctant to add more LLD-specific knowledge into libata
> core. We're already carrying too much due to the current init model
> (libata should initialize host according to probe_ent, so many
> weirdities should be represented in probe_ent in a form libata core
> understands).
>
> * The idea of clearing simplex for unknown controllers scares the hell
> out of me. where's mummy...
>
> So, I'll ask bug reporter of #7590 to test it.

Aieee... uli sata controller doesn't allow simplex bit to be cleared.

http://bugzilla.kernel.org/show_bug.cgi?id=7590#c31

I'll post ATA_FLAG_IGN_SIMPLEX patch soon.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/