Re: [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13

[Catalin Marinas]

On 27/12/06, Ingo Molnar <mingo@xxxxxxx> wrote:
> * Catalin Marinas <catalin.marinas@xxxxxxxxx> wrote:
>
> > On 17/12/06, Ingo Molnar <mingo@xxxxxxx> wrote:
> > >it would be nice to record 1) the jiffies value at the time of
> > >allocation, 2) the PID and the comm of the task that did the allocation.
> > >The jiffies timestamp would be useful to see the age of the allocation,
> > >and the PID/comm is useful for context.
> >
> > Trying to copy the comm with get_task_comm, I get the lockdep report
> > below, caused by acquiring the task's alloc_lock. Any idea how to go
> > around this?
>
> just memcpy p->comm without any locking. It's for the current task,
> right? That does not need any locking.

Yes, it is for the current task. I also added an in_interrupt() test
since the current->comm is not relevant in this case as Arjan pointed
out.

--
Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/