Re: [FSAIO][PATCH 7/8] Filesystem AIO read

[Randy Dunlap]

On Thu, 28 Dec 2006 17:22:07 +0100 (MET) Jan Engelhardt wrote:

> 
> On Dec 28 2006 11:57, Christoph Hellwig wrote:
> >
> >> +
> >> +		if ((error = __lock_page(page, current->io_wait))) {
> >> +			goto readpage_error;
> >> +		}
> >
> >This should  be
> >
> >		error = __lock_page(page, current->io_wait);
> >		if (error)
> >			goto readpage_error;
> 
> That's effectively the same. Essentially a style thing, and I see if((err =
> xyz)) not being uncommon in the kernel tree.

The combined if/assignment has been known to contain coding errors
that are legal C, just not what was intended.

Since the latter replacement shouldn't cause any code efficiency
problems and it's more readable, it's becoming preferred.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/