Re: [PATCH] sound: aoa of_node_put and kfree cleanup
From: Johannes Berg
Date: Tue Jan 02 2007 - 08:13:19 EST
On Tue, 2007-01-02 at 13:50 +0100, Mariusz Kozlowski wrote:
> This patch removes redundant argument checks for of_node_put() and kfree().
Looks good to me, thanks.
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>
Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> sound/aoa/fabrics/snd-aoa-fabric-layout.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
> --- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2006-12-28 12:57:54.000000000 +0100
> +++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c 2007-01-02 01:50:26.000000000 +0100
> @@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
> list_del(&ldev->list);
> layouts_list_items--;
> outnodev:
> - if (sound) of_node_put(sound);
> + of_node_put(sound);
> layout_device = NULL;
> - if (ldev) kfree(ldev);
> + kfree(ldev);
> return -ENODEV;
> }
>
>
>
Attachment:
signature.asc
Description: This is a digitally signed message part