Re: [PATCH] ppc: vio of_node_put cleanup

[Segher Boessenkool]

>  static void __devinit vio_dev_release(struct device *dev)
>  {
> -	if (dev->archdata.of_node) {
> -		/* XXX should free TCE table */
> -		of_node_put(dev->archdata.of_node);
> -	}
> +	/* XXX should free TCE table */
> +	of_node_put(dev->archdata.of_node);
>  	kfree(to_vio_dev(dev));
>  }

The comment used to be inside the "if" block, is this
change correct?

[And, do we want all these changes anyway?  I don't care
either way, both sides have their pros and their cons --
just asking :-) ]


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/