Re: [PATCH] romsignature/checksum cleanup

[Rene Herman]

Zachary Amsden wrote:

> > Rusty Russell wrote:
> >
> > > Rene Herman wrote:
> > >
> > > Hmm, by the way, if romsignature() needs this
> > > probe_kernel_address() thing, why doesn't romchecksum()?
> >
> > I assume it's all in the same page, but CC'ing Zach is easier than 
> > reading the code 8)
>
> Some hypervisors don't emulate the traditional physical layout of the
> first 1M of memory, so those pages might never get physical mappings
> established during the boot process, causing access to them to
> fault. Presumably, if the first page is there with a good signature,
> the entire ROM is mapped.  I think Jeremy added this for Xen, and
> it's harmless on native hardware.

Jeremy? Is it okay to only check the signature word? The checksum will 
generally be done over more than 1 (hw) page... That "presumably" there 
seems a bit flaky?

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/