Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (andv2.6.20-rc3 released))

From: Jeff Garzik
Date: Tue Jan 02 2007 - 20:02:56 EST


Alan wrote:
Once combined mode is fixed not to abuse resources (and it originally
did it that way for a good reason I grant and am not criticising that) the
entire management for legacy mode, mixed mode and native mode resources
for an ATA device (including 0x170, 0x3F6 and other wacky magic) becomes

if (pci_request_regions(pdev, "libata")) ...

Make sense ?

Yes. For 2.6.21. As I've always said.

But for 2.6.20, we are only HALFWAY there, and all these /new/ bugs exist as a result.

Your patch makes far more sense for 2.6.21, where the "halfway to salvation" state, and associated rough edges, is not exposed to users.

Fixing the resource tree was only half the solution, since the drivers that /use/ the resource tree now need updating.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/