Re: [PATCH] i386 kernel instant reboot with older binutils fix

[Eric W. Biederman]

Vivek Goyal <vgoyal@xxxxxxxxxx> writes:

> o i386 kernel reboots instantly if compiled with binutils older than
>   2.6.15.
>
> o Older binutils required explicit flags to mark a section allocatable
>   and executable(AX). Newer binutils automatically mark a section AX if
>   the name starts with .text.
>
> o While defining a new section using assembler "section" directive,
>   explicitly mention section flags. 

As such this patch looks fine, and is certainly harmless.  But don't we
also need to address the issue that .text.head is not listed in the
linker script?

i.e.  Don't we also need?

  .text : AT(ADDR(.text) - LOAD_OFFSET) {
  	_text = .;			/* Text and read-only data */
+	*(.text.head)
	*(.text)
	SCHED_TEXT
	LOCK_TEXT
	KPROBES_TEXT
	*(.fixup)
	*(.gnu.warning)
  	_etext = .;			/* End of text section */
  } :text = 0x9090


I'm not even certain how the i386 kernel links properly without the above.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/