Re: [PATCH] i386 kernel instant reboot with older binutils fix

[Vivek Goyal]

On Wed, Jan 03, 2007 at 02:53:26PM +0100, Adrian Bunk wrote:
> On Wed, Jan 03, 2007 at 09:46:45AM +0530, Vivek Goyal wrote:
> >
> > o i386 kernel reboots instantly if compiled with binutils older than
> >   2.6.15.
> 
> Should that have been "2.15"?
> 

Yes Adrian, it should be 2.15 instead. My mistake.

Hopefully this patch should solve steve's issue too.

Reattaching the patch with corrected changelog.

Thanks
Vivek


o i386 kernel reboots instantly if compiled with binutils older than
  2.15.

o Older binutils required explicit flags to mark a section allocatable
  and executable(AX). Newer binutils automatically mark a section AX if
  the name starts with .text.

o While defining a new section using assembler "section" directive,
  explicitly mention section flags. 

Signed-off-by: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
---

 arch/i386/boot/compressed/head.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/i386/boot/compressed/head.S~jean-reboot-issue-fix arch/i386/boot/compressed/head.S
--- linux-2.6.20-rc2-reloc/arch/i386/boot/compressed/head.S~jean-reboot-issue-fix	2007-01-02 09:54:56.000000000 +0530
+++ linux-2.6.20-rc2-reloc-root/arch/i386/boot/compressed/head.S	2007-01-02 09:57:46.000000000 +0530
@@ -28,7 +28,7 @@
 #include <asm/page.h>
 #include <asm/boot.h>
 
-.section ".text.head"
+.section ".text.head","ax",@progbits
 	.globl startup_32
 
 startup_32:
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/