Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

[Nick Piggin]

Suparna Bhattacharya wrote:
> On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote:

> > Plus Jens's unplugging changes add more reliance upon context inside
> > *current, for the plugging and unplugging operations.  I expect that the
> > fsaio patches will need to be aware of the protocol which those proposed
> > changes add.
>
>
> Whatever logic applies to background writeout etc should also just apply
> as is to aio worker threads, shouldn't it ? At least at a quick glance I
> don't see anything special that needs to be done for fsaio, but its good
> to be aware of this anyway, thanks !

The submitting process plugs itself, submits all its IO, then unplugs
itself (ie. so the plug is now on the process, rather than the block
device).

So long as AIO threads do the same, there would be no problem (plugging
is optional, of course).

This (is supposed to) give a number of improvements over the traditional
plugging (although some downsides too). Most notably for me, the VM gets
cleaner ;)

However AIO could be an interesting case to test for explicit plugging
because of the way they interact. What kind of improvements do you see
with samba and do you have any benchmark setups?

Thanks,
Nick

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/