Re: [PATCH 2.6.19.1-rt15][RFC] - futex_requeue_pi implementation(requeue from futex1 to PI-futex2)

From: Pierre Peiffer
Date: Thu Jan 04 2007 - 03:04:34 EST


Ingo Molnar a écrit :
* Pierre Peiffer <pierre.peiffer@xxxxxxxx> wrote:

Ingo Molnar a écrit :
looks good to me in principle. The size of the patch is scary - is there really no simpler way?
Humf, in fact, for the 64-bit part, I've followed the rule of the existing 64-bit code in futex.c, which consists of duplicating all the functions which can not be kept common, and add a suffix 64 to all duplicated functions. Perhaps I missed something ?

i dont think you missed anything - but some consolidation here would be nice. Only if possible of course :-)

Ok ;-)
So, you are not only speaking about "my" part of duplicated code, right ?
But, just for information, what is the sys_futex64 for, exactly ? Is there a plan to have in the future a 64-bit PID ? Because for now, 32-bits futex is enough, so... ?
Otherwise, I don't have a "clean" way to avoid this duplication.... :-/

--
Pierre Peiffer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/