Re: [PATCH -mm 8/8] user ns: implement user ns unshare

[Serge E. Hallyn]

Quoting Valdis.Kletnieks@xxxxxx (Valdis.Kletnieks@xxxxxx):
> On Thu, 04 Jan 2007 19:07:00 GMT, Frederik Deweerdt said:
> > On Thu, Jan 04, 2007 at 12:13:10PM -0600, Serge E. Hallyn wrote:
> > > From: Serge E. Hallyn <serue@xxxxxxxxxx>
> > > Subject: [PATCH -mm 8/8] user ns: implement user ns unshare
> > >
> > > Implement CLONE_NEWUSER flag useable at clone/unshare.
> > >
> > > Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>
> > > ---
> >
> > >  int copy_user_ns(int flags, struct task_struct *tsk)
> > >  {
> > > -	struct user_namespace *old_ns = tsk->nsproxy->user_ns;
> > > +	struct user_namespace *new_ns, *old_ns = tsk->nsproxy->user_ns;
> > >  	int err = 0;
> >         ^^^^^^^^^^^^
> > The "= 0" is superfluous here.
> 
> Umm?  bss gets cleared automagically, but when did we start auto-zeroing
> the stack?

No, no, that's what i thought he meant at first too, but I actually
manually set err on all paths anyway  :)

-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/