Re: +spin_lock_irq-enable-interrupts-while-spinning-i386-implementation.patchadded to -mm tree

From: Andrew Morton
Date: Sun Jan 07 2007 - 15:05:48 EST


On Sun, 07 Jan 2007 05:24:45 -0800
Daniel Walker <dwalker@xxxxxxxxxx> wrote:

> Now it fails with CONFIG_PARAVIRT off .
>
> scripts/kconfig/conf -s arch/i386/Kconfig
> CHK include/linux/version.h
> CHK include/linux/compile.h
> CHK include/linux/utsrelease.h
> UPD include/linux/compile.h
> CC arch/i386/kernel/asm-offsets.s
> In file included from include/linux/spinlock.h:88,
> from include/linux/module.h:10,
> from include/linux/crypto.h:22,
> from arch/i386/kernel/asm-offsets.c:8:
> include/asm/spinlock.h: In function '__raw_spin_lock_irq':
> include/asm/spinlock.h:100: error: expected string literal before '__CLI_STI_INPUT_ARGS'

bah.

--- a/include/asm-i386/spinlock.h~spin_lock_irq-enable-interrupts-while-spinning-i386-implementation-fix-fix
+++ a/include/asm-i386/spinlock.h
@@ -14,6 +14,7 @@
#define STI_STRING "sti"
#define CLI_STI_CLOBBERS
#define CLI_STI_INPUT_ARGS
+#define __CLI_STI_INPUT_ARGS
#endif /* CONFIG_PARAVIRT */

/*
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/