Re: problems with latest smbfs changes on 2.4.34 and security backports

[Willy Tarreau]

Hi Grant !

On Mon, Jan 22, 2007 at 09:52:44AM +1100, Grant Coady wrote:
> On Fri, 19 Jan 2007 18:05:44 -0700, dann frazier <dannf@xxxxxxxxx> wrote:
> 
> >On Thu, Jan 18, 2007 at 06:00:40PM -0700, dann frazier wrote:
> >Ah, think I see the problem now:
> >
> >--- kernel-source-2.4.27.orig/fs/smbfs/proc.c	2007-01-19 17:53:57.247695476 -0700
> >+++ kernel-source-2.4.27/fs/smbfs/proc.c	2007-01-19 17:49:07.480161733 -0700
> >@@ -1997,7 +1997,7 @@
> > 		fattr->f_mode = (server->mnt->dir_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFDIR;
> > 	else if ( (server->mnt->flags & SMB_MOUNT_FMODE) &&
> > 	          !(S_ISDIR(fattr->f_mode)) )
> >-		fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFREG;
> >+		fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | (fattr->f_mode & S_IFMT);
> > 
> > }
> > 
> client running 2.4.34 with above patch, server is running 2.6.19.2 to 
> eliminate it from the problem space (hopefully ;) :
> grant@sempro:/home/other$ uname -r
> 2.4.34b
> grant@sempro:/home/other$ ls -l
> total 9
> drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dir/
> drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dirlink/
> -rwxr-xr-x 1 grant wheel   15 2007-01-21 11:43 file*
> -rwxr-xr-x 1 grant wheel   15 2007-01-21 11:43 filelink*

It seems to me that there is a difference, because filelink now appears the
same size as file. It's just as if we had hard links instead of symlinks.

> grant@sempro:/home/other$ ls -l dirlink/
> total 1
> -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:44 file*
> -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:44 filelink*
> grant@sempro:/home/other$
> 
> problem is still there :(

At least, directories appear as hard links too.

> With client 2.4.33.3 (slackware-11 distro kernel):
> grant@sempro:/home/other$ uname -r
> 2.4.33.3
> grant@sempro:/home/other$ ls -l
> total 2048
> drwxr-xr-x 1 root root  0 2007-01-21 11:44 dir/
> lrwxrwxrwx 1 root root  3 2007-01-21 11:43 dirlink -> dir/
> -rw-r--r-- 1 root root 15 2007-01-21 11:43 file
> lrwxrwxrwx 1 root root  4 2007-01-21 11:44 filelink -> file
> grant@sempro:/home/other$ ls -l dirlink/
> total 2048
> -rw-r--r-- 1 root root 15 2007-01-21 11:44 file
> lrwxrwxrwx 1 root root  4 2007-01-21 11:44 filelink -> file
> grant@sempro:/home/other$ cat filelink
> this is a test
> 
> No problem with symlinks, execute flag.
>
> Grant.

Thanks for your tests !
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/