Re: Bugfixes: PCI devices get assigned redundant IRQs

[Andreas Block]

On Fri, 26 Jan 2007 12:00:55 +0100, Xavier Bestel <xavier.bestel@xxxxxxx>  
wrote:
> On Fri, 2007-01-26 at 11:50 +0100, Andreas Block wrote:
>
> >   	u8 pin, slot;
> > -	int irq;
> > +	int irq = 0;
>
> Aren't there platforms for which irq = 0 is a valid irq ?

As far as I understand the PCI spec, the answer to your question seems to  
be: no
(or I'm missing something).

Don't get me wrong. I'm not talking about system IRQs, but about the value  
of the Interrupt Pin Register in PCI configuration space.

The PCI Local Bus Specification in Revision 3.0 from 3rd February 2004  
says on page 223 about the content of Interrupt Pin register:

Value 0x00: _No_ interrupt
Values 0x01 to 0x04: Interrupt lines A to D
And values 5 to 0xFF are reserved.

So I'd say, the "correction" of greater values than four to a value of one  
seems discussable, too. Because it will break any future changes of the  
PCI spec.

Andreas

--
-------------------------------------------------------------------------

                            _/_/_/_/   Andreas Block
                           _/_/_/_/   Dipl.-Ing.
                          _/_/_/_/   andreas.block@xxxxxxxxxxxxxxxxxxx

      _/_/_/   _/_/_/_/_/_/_/      esd electronic system design gmbh
    _/   _/  _/             _/    Vahrenwalder Str. 207
   _/   _/    _/_/_/   _/   _/   D-30165 Hannover
   _/             _/  _/   _/   Phone: +49-511-37298-0
    _/_/_/_/_/_/_/   _/_/_/    Fax:   +49-511-37298-68
                              http://www.esd-electronics.com

-------------------------------------------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/