Re: [PATCH] Fix /sys/device/.../power/state regression

From: Greg KH
Date: Fri Jan 26 2007 - 15:42:58 EST


On Thu, Jan 25, 2007 at 05:00:09AM +0000, Matthew Garrett wrote:
> In 2.6.19, support for splitting driver suspend and resume callbacks
> into interrupt and non-interrupt contexts was added. Unfortunately, this
> broke /sys/device/.../power/state support for all devices. In the long
> run, this should be obsoleted by power management support in the
> individual drivers - however, in the case of network drivers (for
> example), currently only three drivers implement any sort of useful
> run-time power management.
>
> This patch allows the bus driver to check whether a specific driver
> requires the split. If not, the 2.6.18 functionality is restored. It
> also alters feature-removals.txt to note that the deprecated
> functionality should not be removed until a replacement actually exists.

Ick, no.

As stated before, it was broken in the past, and no userspace tools use
it because of that. So it was disabled.

Or am I misstating that long thread? David, your thoughts?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/