Re: [PATCH] 4/5: Updates to SPI and mmc_spi: mmc_spi updated, kernel 2.6.19

[David Brownell]

On Friday 26 January 2007 8:49 am, Pierre Ossman wrote:
> Hans-Peter Nilsson wrote:
> > 
> > Future improvements:
> > A rewrite.  Not only for the new MMC framework (I haven't looked
> > at it so I don't know what's involved) but also because this
> > code seems a little too, um, experimental to fit my taste.
> > Functions go behind each other's back and look at and change
> > data; they seem to "fix up" the result of each others work.

(Like the MMC layer's retry mechanism ...)


> > It doesn't help maintenance.
> 
> Right, this isn't getting merged anywhere near its current state. It
> should be implemented as a host driver and we'll modify the mmc core
> where needed to cover the differences when doing spi.
> 
> As for my "new framework", it's mostly reorganising the stuff already
> there. But any patches will have to be reworked after that change. So
> I'd suggest holding off on this for a while.

That goes without saying, since this driver currently needs some
updates to the SPI framework (grabbing the whole bus, locking out
other devices) that aren't yet mergeable.

However I'm glad to see that, courtesy of Hans-Peter, we now seem
to have enough of the MMC-over-SPI behaving that we can start to
fill in those missing pieces ... and explore just what changes
would be needed in the MMC/SD core!

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/