Re: + oops-in-drivers-net-shaperc.patch added to -mm tree

From: David Miller
Date: Fri Jan 26 2007 - 22:11:09 EST


From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 27 Jan 2007 11:45:05 +1100

> David Miller <davem@xxxxxxxxxxxxx> wrote:
> >
> > Shaper is actually OK. None of these hardware header callbacks
> > should be invoked if the device is down. Yet, this is what is
> > accidently being allowed in the AF_PACKET socket layer.
>
> Hmm, what if the device goes down after the check?

For the shaper case it's OK, because once a shaper is
associated it's ->dev never goes back to NULL.

In general, yes it's a problem :-/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/