Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

From: Hans-Peter Nilsson
Date: Sat Jan 27 2007 - 05:19:47 EST


> From: David Brownell <david-b@xxxxxxxxxxx>
> Date: Fri, 26 Jan 2007 15:21:15 -0800

> > > That flag could work in conjunction with a byte
> >
> > Or why not a 32-bit word!
>
> If a driver wants a repeating 32-bit pattern, they should just
> provide a properly initialized tx buffer.

I'm suggesting the default_tx_word be able to fill out "common"
values of bits_per_word when > 8, else it'd be useless as a
1-filler for larger sizes than byte. Making it a single bit
then wouldn't cater to your debug-with-scope use-case.

brgds, H-P
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/