Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

[Randy Dunlap]

Adrian Bunk wrote:
> On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote:
> > From: Adrian Bunk <bunk@xxxxxxxxx>
> > Date: Mon, 29 Jan 2007 01:00:11 +0100
> >
> > > On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote:
> > > > Adrian is this the correct way to constrain the selection between
> > > > "n" and "m" in this kind of situation?  I thought doing something
> > > > like "depends on IPV6" is sufficient to achieve that?
> > > "depends on IPV6" would fix the bug - but it would also make 
> > > NF_CONNTRACK_H323 unavailable for all people without IPV6 support in 
> > > their kernel.
> > Yes, that is an issue.
> >
> > I guess with some slightly ugly ifdefs we could support the
> > whole matrix of possibilities.  But perhaps that's undesirable
> > for another reason.
> > ...
>
> This depends on what NF_CONNTRACK_H323=y, IPV6=m is supposed to be:
> - not allowed (NF_CONNTRACK_H323 must be modular) or
> - NF_CONNTRACK_H323 can only be used for IPV4
>
> My patch implements the first case.

Sorry for the slow reponse.  This bug only came up due to my
bad gfs2/dlm patch, which Adrian has now corrected, so I think
you can just drop this patch.  It now builds for me with only
Adrian's gfs2/dlm patch applied.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/