Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

From: Andrew Morton
Date: Mon Jan 29 2007 - 04:00:10 EST


On Mon, 29 Jan 2007 03:51:54 +0100
Andi Kleen <ak@xxxxxxx> wrote:

>
> > I think the easy and correct fix for this situation is defining
> > CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if
> > IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to
> > require arch_setup_additional_pages() only IA32 emulation requires
> > it.)
> >
> > The patch below should fix it. (Please use attachment - less chance of
> > whitespace issues. Sorry no control over mail client atm)
>
> A more elegant solution would be to do away with the CONFIG
> and switch to a weak function in the caller.
>

Now why didn't I think of that?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/