Re: [PATCH] pata_platform: fallout from set_mode() change

From: Jeff Garzik
Date: Tue Jan 30 2007 - 09:13:17 EST


Paul Mundt wrote:
On Tue, Jan 30, 2007 at 08:36:28AM -0500, Jeff Garzik wrote:
Al Viro wrote:
Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
This is already in the queue via Andrew, who caught the same problem.

Sometimes it seems like you and Andrew are the only people to build on non-x86 these days...

This is the first I've heard of this or the changes that caused this,
while I do build current git on a pretty much daily basis, -mm doesn't
get nearly as much testing.

There are many people who build on non-x86 every day, there are rather
less people who have the bandwidth for -mm as well as current git or
for tracking down changes that haven't made it upstream to make sure
everything plays nice.

If you want immediate action, I suggest you CC the authors of the drivers
when there's changes they should be made aware of, rather than deferring
to hand-waving generalizations about how no one does any testing after
the fact.

The change in question is in the current -git. But my comment was largely self-critical, since /I/ applied the patch in question that broke on non-x86.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/