Re: [PATCH 5/5] KVM: Host suspend/resume support

From: Nigel Cunningham
Date: Tue Jan 30 2007 - 19:43:05 EST


Hi.

On Tue, 2007-01-30 at 23:19 +0100, Rafael J. Wysocki wrote:
> On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote:
> > Hi.
> >
> > On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote:
> > > Add the necessary callbacks to suspend and resume a host running kvm. This
> > > is just a repeat of the cpu hotplug/unplug work.
> > >
> > > Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx>
> >
> > Maybe it's just a lack of understanding, but I'm wondering if this patch
> > is necessary - we already hot-unplug secondary cpus prior to suspending
> > devices.
>
> Not with the reoredering patches that are in -mm, though. With these patches,
> the nonboot CPUs are disabled after "regular" devices.

Ah. Good point. Thanks! :)

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/