Re: [PATCH] scsi_lib.c: continue after MEDIUM_ERROR

[Mark Lord]

Eric D. Mudama wrote:
> Actually, it's possibly worse, since each failure in libata will 
> generate 3-4 retries.  With existing ATA error recovery in the drives, 
> that's about 3 seconds per retry on average, or 12 seconds per failure.  
> Multiply that by the number of blocks past the error to complete the 
> request..

It really beats the alternative of a forced reboot
due to, say, superblock I/O failing because it happened
to get merged with an unrelated I/O which then failed..
Etc..

Definitely an improvement.

The number of retries is an entirely separate issue.
If we really care about it, then we should fix SD_MAX_RETRIES.

The current value of 5 is *way* too high.  It should be zero or one.

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/