Re: [PATCH 16/23] clocksource: arm update for new flags

From: Ingo Molnar
Date: Wed Jan 31 2007 - 07:29:09 EST



* Daniel Walker <dwalker@xxxxxxxxxx> wrote:

> Update ARM for new flags.
>
> Signed-Off-By: Daniel Walker <dwalker@xxxxxxxxxx>

> - .flags = CLOCK_SOURCE_IS_CONTINUOUS,

see my general objection to this change (under the [PATCH 22/23]
subject), but even looking at the pure patch note that it does the flag
update incorrectly and in a bisect-boot-unfriendly way: the queue at
this point changes kernel functionality and has side-effects. The right
way to do flags updates is to first introduce them, then change things
over.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/