Re: Rewriting floppy.c was Re: Free Linux Driver Development!

From: Al Viro
Date: Thu Feb 01 2007 - 12:14:21 EST


On Thu, Feb 01, 2007 at 02:12:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On 31 Jan 2007 11:08:14 +0100, Andi Kleen <ak@xxxxxxx> wrote:
> >Greg KH <greg@xxxxxxxxx> writes:
> >>
> >> What? Throw a fresh-faced newbie instantly into the tar-pit of despair
> >> that floppy.c is? Do you want everyone just to run screaming from
> >> kernel development never to be seen again?
>
> floppy.c is not really that ugly or complicated...
>
> It just needs some care:
>
> * cleanup of the over-usage of macros (DP macro etc)
> * DocBook documentation would be nice
> * make debugging printks optional by using macros in a smart way
> (see libata code for examples)
> * tracking and fixing current regressions

* piece of shit FSM buried in various continuation methods.
* one hell of a problem with regression testing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/