Re: [PATCH] CELL PPU Oprofile cleanup patch

From: Michael Neuling
Date: Thu Feb 01 2007 - 17:52:48 EST


Carl,

> +#define NUM_TRACE_BUS_WORDS 4
> +#define NUM_INPUT_BUS_WORDS 2

<snip>

> - for (i = 0; i < 4; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> trace_bus[i] = 0xff;
>
> - for (i = 0; i < 2; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> input_bus[i] = 0xff;

The first loop looks like a bug... Shouldn't it be NUM_TRACE_BUS_WORDS?

Mikey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/