Re: Please revert "fix typo in geode_configre()@cyrix.c"

From: Juergen Beisert
Date: Fri Feb 02 2007 - 03:40:54 EST


On Friday 02 February 2007 07:29, Adrian Bunk wrote:
> Since there is AFAIK no actually observed problem fixed by this, it
> should be safe to simply revert the patch for 2.6.20.

The most important fix was:

Index: linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
===================================================================
--- linux-2.6.19.orig/arch/i386/kernel/cpu/cyrix.c
+++ linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
@@ -173,6 +173,7 @@ static void __cpuinit geode_configure(vo
ccr4 = getCx86(CX86_CCR4);
ccr4 |= 0x38; /* FPU fast, DTE cache, Mem bypass */

+ setCx86(CX86_CCR4, ccr4);
setCx86(CX86_CCR3, ccr3);

set_cx86_memwb();

to write back the modified register content. But yes, it works also without
this fix (but faster with it).

Juergen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/