Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

[Auke Kok]

Alexey Dobriyan wrote:
> On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote:
> > A patch to use ARRAY_SIZE macro already defined in kernel.h.
>
> Remove it and use ARRAY_SIZE instead.
>
> > --- a/drivers/net/ixgb/ixgb_param.c
> > +++ b/drivers/net/ixgb/ixgb_param.c
> > @@ -245,7 +245,7 @@ ixgb_validate_option(int *value, struct ixgb_option *opt)
> >  	return -1;
> >  }
> >  
> > -#define LIST_LEN(l) (sizeof(l) / sizeof(l[0]))
> > +#define LIST_LEN(l) ARRAY_SIZE(l)

yes, well spotted. Please change line 338 in this file to read:

     .arg  = { .l = { .nr = ARRAY_SIZE(fc_list),

instead, so you can remove the LIST_LEN macro completely.

Thanks,

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/