Re: [patch 1/1] PM: Adds remount fs ro at suspend

From: Christoph Hellwig
Date: Mon Feb 05 2007 - 16:36:35 EST


On Tue, Feb 06, 2007 at 08:28:33AM +1100, Nigel Cunningham wrote:
> Why do you think remounting filesystems is necessary? Are you getting
> problems with some particular filesystem?
>
> If I recall correctly, we briefly tried remounting filesystems in
> Suspend2, but it created problems with logging - some files open r/w
> were readonly afterwards.

Yes, that's the biggest problem with the forced remount r/o hack -
FMODE_WRITE is dropped from all files, and can't be recovered.
(and at the same time in progress writes or writes through shared
mmaps are totally ignored).

> We then tried bdev freezing with much better success.

Yes, that's the right thing to do if you want to be safe, but
we already had that discussion..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/