Re: [PATCH]: warrning fix: unsigned->signed

[Jens Axboe]

On Tue, Feb 06 2007, Andrew Morton wrote:
> On Wed, 7 Feb 2007 00:39:45 +0300
> "Tomasz Kvarsin" <kvarsin@xxxxxxxxx> wrote:
> 
> > While compiling my code, I always get bunch of warrning from headers,
> > here is fix for them:
> > __getblk is alawys called with unsigned argument,
> > but it takes signed, the same story with __bread,__breadahead and so on.
> 
> The patch seems OK, but I'm curious to know why you're seeing this warning
> and nobody else is.  Are you using a compiler other than gcc?  If gcc,
> which version?  Did you add any new compiler options?

While I'm not a big fan of fixing signed vs unsigned -W generated
warnings (they tend to cause more harm than good), this patch looks ok
to me as well.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/