Re: [PATCH] pata_acpi: take two

From: Mariusz Kozlowski
Date: Wed Feb 07 2007 - 15:38:13 EST


Hello,

Just asking ... in:

> +static void *ata_pata_find_handle(struct device *dev, int port)

...

> + chan_handle = acpi_get_child(handle, port);
> + if (chan_handle == NULL)
> + return NULL;
> + return chan_handle;
> +}

why not simply:

return acpi_get_child(hadnle, port);

?

Regards,

Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/