Kbuild refactoring (Re: The who needs reviews anyways [PATCH])

From: Oleg Verych
Date: Thu Feb 08 2007 - 17:55:34 EST


On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote:
[]
> - printf has other side effects, instead stop pretending we support
> something else than bash

Yes. With `%' in option strings there will be side effects.
I would suggest to use

printf %s "$(1)"

with "paranoia mode on", and hope to do not forcing `bash'.

> - proper quoting
> - proper indentation
>
> bye, Roman

Thanks.

____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/