Re: [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declarationfrom smpboot.c
From: Zachary Amsden
Date: Mon Feb 12 2007 - 04:17:06 EST
Rusty Russell wrote:
When I implemented the DECLARE_PER_CPU(var) macros, I was careful that
people couldn't use "var" in a non-percpu context, by prepending
percpu__. I never considered that this would allow them to overload
the same name for a per-cpu and a non-percpu variable.
It is only one of many horrors in the i386 boot code, but let's rename
the non-perpcu cpu_gdt_descr to early_gdt_descr (not boot_gdt_descr,
that's something else...)
Finally, someone not just noticed, but fixed it! Thank you Rusty. Was
on my todo list, but never bubbled up.
Acked-by: Zachary Amsden <zach@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/