Re: [PATCH] Move include linux/marker.h to kernel.h

[Andrew Morton]

On Fri, 16 Feb 2007 13:05:13 -0500 Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> Move include linux/marker.h to kernel.h
> 
> * Andrew Morton (akpm@xxxxxxxxxxxxxxxxxxxx) wrote:
> > Oh.  One could whack [include linux/marker.h] in kernel.h: pretty
> > much everything includes that.
> > 
> > But it'd be better to simply require that the clients of this
> > infrastructure include the appropriate header file.  We do that for
> > everything else and markers aren't special in this regard.
> 
> It seems like the logical solution. This patch moves this include from
> Makefile to include/linux/kernel.h.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
> 
> --- a/Makefile
> +++ b/Makefile
> @@ -308,9 +308,7 @@ AFLAGS_KERNEL	=
>  # Needed to be compatible with the O= option
>  LINUXINCLUDE    := -Iinclude \
>                     $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> -		   -include include/linux/autoconf.h \
> -		   -include \
> -		   	$(if $(KBUILD_SRC),$(srctree)/)include/linux/marker.h
> +		   -include include/linux/autoconf.h
>  
>  CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
>  
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -14,6 +14,7 @@
>  #include <linux/compiler.h>
>  #include <linux/bitops.h>
>  #include <linux/log2.h>
> +#include <linux/marker.h>
>  #include <asm/byteorder.h>
>  #include <asm/bug.h>

No, that's still crufty.  There's no reason why marker.h needs special
treatment whereas, say, jiffies.h does not (is there?)

It is conventional and reasonable to require that any code which uses this
mechanism must include its header file.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/