Balbir Singh wrote:Paul Menage wrote:On 2/19/07, Balbir Singh <balbir@xxxxxxxxxx> wrote:Yes, that sounds like the correct thing to do.... or have been moved to other containers. If you're not holdingMore worrisome is the potential for use-after-free. What prevents theThe container cannot be freed unless all tasks holding references to it are
pointer at mm->container from referring to freed memory after we're dropped
the lock?
gone,
task->alloc_lock or one of the container mutexes, there's nothing to
stop the task being moved to another container, and the container
being deleted.
If you're in an RCU section then you can guarantee that the container
(that you originally read from the task) and its subsystems at least
won't be deleted while you're accessing them, but for accounting like
this I suspect that's not enough, since you need to be adding to the
accounting stats on the correct container. I think you'll need to hold
mm->container_lock for the duration of memctl_update_rss()
Paul
Accounting accuracy will anyway be affected when a process is migrated
while it is still allocating pages. Having a lock here does not
necessarily improve the accounting accuracy. Charges from the old
container would have to be moved to the new container before deletion
which implies all tasks have already left the container and no
mm_struct is holding a pointer to it.
The only condition that will break our code will be if the container
pointer becomes invalid while we are updating stats. This can be
prevented by RCU section as mentioned by Paul. I believe explicit
lock and unlock may not provide additional benefit here.
--Vaidy