Re: [PATCH] pci: allow multiple calls to pcim_pin_device()

From: Ian McDonald
Date: Tue Feb 20 2007 - 16:45:56 EST


On 2/20/07, Tejun Heo <htejun@xxxxxxxxx> wrote:
Sanity check in pcim_pin_device() was too restrictive in that it
didn't allow multiple calls to the function, which is against the
devres philosohpy of fire-and-forget. Track pinned status separately
and allow pinning multiple times.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---
It was an actual bug in pcim_pin_device() implementation. Thanks for
spotting this. :-)

Ian McDonald, please verify your warning goes away with this patch.

Yes it does. Thanks for sorting.

Greg, please forward this patch upstream once Ian acks it.

Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>
--
Web: http://wand.net.nz/~iam4
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/