Re: [PATCH] fault injection: split up stacktrace filter Kconfig option

[Dave Jones]

On Wed, Feb 21, 2007 at 01:59:09AM +0000, Linux Kernel wrote:
 > Commit:     1df49008f4ddec9d4f6862b47ea5bdba82078aa4
 > Parent:     94412a96c4553255bda7a232a349059dd7543338
 > Author:     Akinobu Mita <akinobu.mita@xxxxxxxxx>
 > AuthorDate: Tue Feb 20 13:57:56 2007 -0800
 > Committer:  Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>
 > CommitDate: Tue Feb 20 17:10:14 2007 -0800
 > 
 >     [PATCH] fault injection: split up stacktrace filter Kconfig option
 >     
 >     There is no prompt for CONFIG_STACKTRACE, so FAULT_INJECTION cannot be
 >     selected without LOCKDEP enabled.  (found by Paolo 'Blaisorblade'
 >     Giarrusso)
 >     
 >     In order to fix such broken Kconfig dependency, this patch splits up the
 >     stacktrace filter support for fault injection by new Kconfig option, which
 >     enables to use fault injection on the architecture which doesn't have
 >     general stacktrace support.

 ...

 > +config FAULT_INJECTION_STACKTRACE_FILTER
 > +	bool "stacktrace filter for fault-injection capabilities"
 > +	depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
 > +	select STACKTRACE
 > +	select FRAME_POINTER
 > +	help
 > +	  Provide stacktrace filter for fault-injection capabilities

This help text is pretty useless. It tells the person configuring
nothing about what a stacktrace filter is, or why it might be useful.
helptexts that just parrot the name of the option might as well not be there.

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/