Re: [PATCH 2/3] Don't change transfer speed while requests are inflight

From: Alan
Date: Wed Feb 21 2007 - 07:09:35 EST


> + * If we are in an interrupt, it should be safe to issue
> + * SETFEATURES manually, since there shouldn't be any requests in
> + * flight.

There may be error recovery going on from a timeout on another processor.
I don't see how your code protects against that (and the old code is
broken too)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/