Re: securityfs_create_dir strange comment

From: Jan Engelhardt
Date: Wed Feb 21 2007 - 12:09:18 EST


Hello Greg,


On Feb 20 2007 20:05, Greg KH wrote:
>
>Try this instead:
> if (!de)
> return -ENOMEM;
> if ((IS_ERR(de)) && (PTR_ERR(de) != -ENODEV))
> return PTR_ERR(de);
> return 0;
>
>That should cover everything properly, right?

In case memory could not be allocated, why does not securityfs_*() return
ERR_PTR(-ENOMEM) then? (I think, that's the quintessential question after
all. And thanks for giving an example what to do in the ENODEV case.)


Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/