Re: Linux 2.6.21-rc1

[Andrew Morton]

On Wed, 21 Feb 2007 11:24:33 -0800 (PST)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> 
> 
> On Wed, 21 Feb 2007, Kok, Auke wrote:
> > 
> > I think we need to drop this now. The report that says that this *fixes*
> > something might have been on regular interrupts only. I currently suspect that
> > it breaks all MSI interrupts, which would make sense if I look a the code.
> > Very bad indeed.
> > 
> > I'll try to come up with something else or send a patch that reverts it.
> 
> I'm going to be off-line for a couple of days,

And I'll be offline for five or six days.

> so I just reverted it.

OK, but this change was needed because the new IRQ-debugging code reliably
causes e1000 to explode.

So perhaps until e1000 gets sorted out we should disable the debug code:

--- a/lib/Kconfig.debug~a
+++ a/lib/Kconfig.debug
@@ -79,7 +79,7 @@ config DEBUG_KERNEL
 
 config DEBUG_SHIRQ
 	bool "Debug shared IRQ handlers"
-	depends on DEBUG_KERNEL && GENERIC_HARDIRQS
+	depends on DEBUG_KERNEL && GENERIC_HARDIRQS && BROKEN
 	help
 	  Enable this to generate a spurious interrupt as soon as a shared
 	  interrupt handler is registered, and just before one is deregistered.
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/