Re: [uml-devel] [PATCH] UML - Fix 2.6.20 hang

[Blaisorblade]

On Thursday 15 February 2007 18:07, Jeff Dike wrote:
> Signed-off-by: Jeff Dike <jdike@xxxxxxxxxxx>
[...]
> @@ -331,10 +334,9 @@ void maybe_sigio_broken(int fd, int read
>
>  	sigio_lock();
>  	err = need_poll(&all_sigio_fds, all_sigio_fds.used + 1);
> -	if(err){
> -		printk("maybe_sigio_broken - failed to add pollfd\n");
> +	if(err)
>  		goto out;
> -	}
> +
>  	all_sigio_fds.poll[all_sigio_fds.used++] =
>  		((struct pollfd) { .fd  	= fd,
>  				   .events 	= read ? POLLIN : POLLOUT,
>
Was that removal wanted or it happened by mistake? That way, err is completely 
lost.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/