RE: [PATCH] ACPI driver support for pata

[Allen Martin]

> Couldn't be do this generically inside libata core somehow, 
> i.e. try to 
> use ACPI to set the proper mode and fall back to the driver-specific 
> mode setting code if that didn't work? I think if we could do that it 
> would solve a number of problems (i.e. we could prevent it from doing 
> this on SATA controllers which appear to be IDE based on the PCI ID, 
> like the NVIDIA SATA controllers, since the _GTM and _STM 
> methods seem 
> to have undefined behavior on SATA). 

_GTM and _STM don't have undefined behavior on SATA.  They are there for
compatability with the MS Windows ATA driver.  Any SATA device that
reports PCI class code 0101 should implement them if that controller is
supposed to work on Windows.  They are NOPs for SATA controllers
generally.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/