Re: [PATCH] Fix soft lockup with iSeries viocd driver

[Andrew Morton]

On Thu, 1 Mar 2007 14:56:40 +1100 tony@xxxxxxxxxxxxxxxxxx (Tony Breeds) wrote:

> From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
> 
> Fix soft lockup with iSeries viocd driver, caused by eventually calling
> end_that_request_first() with nr_bytes 0.
> 
> The lockup is triggered by hald, interrogating the device.
> 

What causes the lockup, and how does this patch fix it?

> 
> Index: linux-2.6.20-rc5/drivers/cdrom/viocd.c
> ===================================================================
> --- linux-2.6.20-rc5.orig/drivers/cdrom/viocd.c
> +++ linux-2.6.20-rc5/drivers/cdrom/viocd.c
> @@ -376,6 +376,25 @@ static int send_request(struct request *
>         return 0;
>  }
>  
> +static void viocd_end_request(struct request *req, int uptodate)
> +{
> +       int nsectors = req->hard_nr_sectors;

Your email client replaces tabs with spaces.  I fixed this patch up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/