Re: minor device number request for /dev/kvm (kernel-based virtualmachine)

From: Avi Kivity
Date: Thu Mar 01 2007 - 08:07:37 EST


Jan Engelhardt wrote:
On Mar 1 2007 13:58, Avi Kivity wrote:
fs/char_dev.c:
int register_chrdev(unsigned int major, const char *name,
const struct file_operations *fops)
{
struct char_device_struct *cd;
struct cdev *cdev;
char *s;
int err = -ENOMEM;

cd = __register_chrdev_region(major, 0, 256, name);
So misc minor numbers under 256 are not supported.

What's the way out? Increase the region size? I don't know if that's safe.

If it does not increase memory usage, then possibly:

__register_chrdev_region(major, 0, (~0U) & MINORMASK, name);
or (1<<MINORMASK)-1 if that's more clear


I'm more worried about something in the chardev bowels not supporting >8bit minors well.


--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/