Re: [PATCH] libata: Cable detection fixes

[Jeff Garzik]

Linus Torvalds wrote:
> On Thu, 1 Mar 2007, Alan wrote:
> > The patch switches the identify order so that we can do the drive side
> > detection correctly. 
> >
> > Secondly we add a ->cable_detect() method called after the identify
> > sequence which allows a host to do host side detection at this point
> > should it wish, or to modify the results of the drive side identify.
>
> Alan, sign-offs?
>
> Jeff, should I just expect to get these things through you?

See my reply, which passed yours in-flight :)

I'm OK with all the changes, but ->cable_detect (and _nice_ cleanups) 
does not seem like 2.6.21-rc bugfix material to me.

We definitely want the IDENTIFY ordering changes, though we'll also want 
that passed through at least one more 2.6.21-rcX release before 
confidence appears.

That little change, buried in the middle of Alan's patch, changes the 
probing order for a /lot/ of devices, possibly millions, when you 
consider that it changes behavior of ata_piix (Intel SATA) as well as 
all the not-yet-default PATA controllers.

A wanted fix, but something that definitely wants a lot of public 
testing before 2.6.21 release.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/