Re: [PATCH] pata_legacy: Fix missing methods and add cable types

From: Jeff Garzik
Date: Fri Mar 02 2007 - 18:12:47 EST


Alan wrote:
Several method sets lacked freeze/resume methods. Fix this and while we
are at it force the cable to 40wire

Signed-off-by: Alan Cox <alan@xxxxxxxxxx>

For this, pata_sc1200 and pata_sl82c105: applied the missing-hook portion of the patch, and dropped the ->cable_detect portion pending resend.

Please resend the cable_detect patches one this other stuff lands (will push tonight). I would suggest doing two patches:

1) add ->cable_detect hook
2) use ->cable_detect in PATA drivers

There is no need to split up the same change across multiple drivers. It is the same logical change, and people doing git-bisect won't be left with a broken configuration, so a single update-drivers patch makes more sense. And, hopefully, is less work for you.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/