Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

[Jeff Garzik]

Alan Cox wrote:
> > it seems broken to manipulate xfer_mask after returning from the 
> > driver's ->mode_filter hook.
> >
> > this patch is more than just a speed-limited warning printk, afaics
>
> I actually suggested that order because the only way the printk can be
> done correctly is for it to be the very last test made. Since the mode
> filter is not told what mode will be used but just subtracts modes that
> are not allowed this should be safe.

OK


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/