Re: [S390] Use generic bug.

From: David Miller
Date: Mon Mar 05 2007 - 17:56:49 EST


From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
Date: Mon, 5 Mar 2007 23:43:54 +0100

> + if (__builtin_constant_p(__ret_warn_on)) { \
> + if (__ret_warn_on) \
> + __EMIT_BUG(BUGFLAG_WARNING); \

I see we'll have this construct on powerpc, parisc and now s390.

But if it's going to trigger essentially at compile time, I
think it's much better to BUILD_BUG_ON() in this case instead
of counting on the code path to actually run and the user to
notice and report the kernel log message.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/