RE: [patch 1/1] ppc: Possible bug fix for FCC driver

[Li Yang-r58472]

Hi Cedric,

For ppc embedded related patches, please also cc:
linuxppc-embedded@xxxxxxxxxxx

> We use a kernel 2.6.14 on PPC platform (MPC 8555). The FCC driver
works

To submit a kernel patch upstream, the patch should be against the
latest kernel version which is 2.6.21-rc now.
> well with a 100Mbps link. But it doesn't with a 10Mbps link. To solve
> it, I modified the GFMR register init: removed TCI bit and set CRC32
bit
> instead of.

I don't know how these bits caused the 10M link issue.  Do you have any
reasoning?

> 	Signed-off-by: Cedric Pontois <cpontois@xxxxxxxxxx>
> 
>
------------------------------------------------------------------------
> -----
> 
> diff -ruN pa-original/arch/ppc/8260_io/fcc_enet.c
> pa-patched/arch/ppc/8260_io/fcc_enet.c
> --- pa-original/arch/ppc/8260_io/fcc_enet.c	2007-03-02
> 14:57:07.000197000 +0100
> +++ pa-patched/arch/ppc/8260_io/fcc_enet.c	2007-03-02
> 14:57:08.000038000 +0100
> @@ -2232,7 +2232,7 @@
> 
>  	/* Set GFMR to enable Ethernet operating mode.
>  	 */
> -	fccp->fcc_gfmr = (FCC_GFMR_TCI | FCC_GFMR_MODE_ENET);
> +	fccp->fcc_gfmr = (FCC_GFMR_TCRC_32 | FCC_GFMR_MODE_ENET);
> 
>  	/* Set sync/delimiters.
>  	*/
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/